Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove carriage returns from build info json file #6180

Merged

Conversation

@czoido
Copy link
Contributor

czoido commented Dec 4, 2019

Changelog: Bugfix: Remove carriage returns from build info .json file to avoid Artifactory errors in some cases when publishing the build info to the remote.
Docs: Omit

It looks like in some cases the build info publishing failed with an ERROR: 400: Bad Request if the file contained carriage returns.

Closes #6103

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

@czoido czoido added this to the 1.21 milestone Dec 4, 2019
@czoido czoido self-assigned this Dec 4, 2019
@lasote lasote assigned lasote and unassigned czoido Dec 4, 2019
@lasote lasote merged commit ac74232 into conan-io:develop Dec 4, 2019
2 checks passed
2 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.