Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use sh instead of bash #6203

Merged
merged 2 commits into from Dec 10, 2019
Merged

Use sh instead of bash #6203

merged 2 commits into from Dec 10, 2019

Conversation

lasote
Copy link
Contributor

@lasote lasote commented Dec 10, 2019

Changelog: omit
Docs: omit

#5989 (comment)

I would say everything on there are standard shell commands, nothing bash specifics, right? @jgsogo
It might happen that bash is not in the system.

@lasote lasote requested a review from jgsogo December 10, 2019 07:20
@lasote lasote added this to the 1.21 milestone Dec 10, 2019
@Morwenn
Copy link
Contributor

Morwenn commented Dec 10, 2019

BASH_SOURCE does look like something that could be bash-specific.

@jgsogo
Copy link
Contributor

jgsogo commented Dec 10, 2019

The line with the BASH_SOURCE is commented (and can be removed). It is legacy from a trial I did to retrieve the directory for the current script file, but, as it was not always accurate, I decided to use the full path for the environment_file placeholder.

jgsogo
jgsogo approved these changes Dec 10, 2019
View reviewed changes
Copy link
Contributor

@jgsogo jgsogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think all of it should be valid for any sh implementation.

@lasote
Copy link
Contributor Author

lasote commented Dec 10, 2019

Removed comments

@lasote lasote merged commit 3d91b59 into conan-io:release/1.21.0 Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgsogo jgsogo jgsogo approved these changes

Assignees

@jgsogo jgsogo

Labels
None yet
Projects
None yet
Milestone
1.21
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lasote @Morwenn @jgsogo