include macos frameworks in autotools LDFLAGS

[ericLemanissier]

Changelog: Bugfix: Include MacOS frameworks definitions in autotools LDFLAGS (also Meson).
Changelog: Bugfix: Apply system_libs information in autotools build helper.
Docs: Omit

[memsharded]

There are a few broken tests, many because of a Mock missing data.

Could you please elaborate a bit more about this? Is it really possible to inject the frameworks as they are into LD_FLAGS?

[memsharded]

Asking for the help of @SSE4 to check this PR, and help making it green if it makes sense.

[SSE4]

yeas, there are mocks need to be fixed, I'll take a look

[ericLemanissier]

I think system_libs should also be added
Sorry, this PR lacks context. I'll take the time to find what failed, and why this PR should fix it, probably in the coming days.

[SSE4]

@ericLemanissier could you give me write permissions to your fork? thx.

[SSE4]

@ericLemanissier @memsharded
I went ahead and fixed errors in tests. for me the PR makes total sense, as frameworks and system libraries should be respected by AutoToolsBuildEnvironment helper (otherwise, certain projects may not configure properly).

[ericLemanissier]

Thanks a lot @SSE4 !
also, this PR fixes the same issue with meson builds because Meson build helper internally uses AutoToolsBuildEnvironment

[memsharded]

Thanks all.

I have tentatively assigned it for Conan 1.22, let's wait for @jgsogo and @danimtb review.

[danimtb]

LGTM although I am missing a test with input values for both system_libs and frameworks and asserts on the output of the autotools helper

[memsharded]

LGTM although I am missing a test with input values for both system_libs and frameworks and asserts on the output of the autotools helper

Yes, definitely, this deserves a test with some values in both, because it is green, but the truth is that it could be doing nothing and we would never know, or worse, we can break it in the future and not be aware.

Please @SSE4 try to add one or two tests that use some actual values for those. Many thanks!

[ericLemanissier]

ok, unit tests are now passing on my computer

[memsharded]

I have merged from develop, because we have added Py38 testing, and some tests have been fixed in develop to pass in Py38