Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unathorized transfers #6317

Merged

Conversation

@memsharded
Copy link
Member

memsharded commented Jan 9, 2020

Changelog: Bugfix: Fix uninformative crash when tools.download() gets a 403 and it is not providing an auth field.
Docs: Omit

Close #6316
#tags: slow

@memsharded memsharded added this to the 1.21.1 milestone Jan 9, 2020
Copy link
Member

jgsogo left a comment

Please, check that the ConanException is related to the server error in the last test

conans/test/unittests/util/tools_test.py Outdated Show resolved Hide resolved
@jgsogo
jgsogo approved these changes Jan 9, 2020
Copy link
Member

jgsogo left a comment

The TODO is something to investigate, but we can leave with it for this minor

@jgsogo jgsogo merged commit 47fb823 into conan-io:release/1.21.1 Jan 9, 2020
2 checks passed
2 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details
@memsharded memsharded deleted the memsharded:fix/unathorized_transfers branch Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.