Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix unathorized transfers #6317

Merged
merged 2 commits into from Jan 9, 2020
Merged

fix unathorized transfers #6317

merged 2 commits into from Jan 9, 2020

Conversation

memsharded
Copy link
Member

Changelog: Bugfix: Fix uninformative crash when tools.download() gets a 403 and it is not providing an auth field.
Docs: Omit

Close #6316
#tags: slow

@memsharded memsharded added this to the 1.21.1 milestone Jan 9, 2020
jgsogo
jgsogo suggested changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@jgsogo jgsogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, check that the ConanException is related to the server error in the last test

conans/test/unittests/util/tools_test.py Outdated Show resolved Hide resolved
jgsogo
jgsogo approved these changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@jgsogo jgsogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TODO is something to investigate, but we can leave with it for this minor

@jgsogo jgsogo merged commit 47fb823 into conan-io:release/1.21.1 Jan 9, 2020
@memsharded memsharded deleted the fix/unathorized_transfers branch January 9, 2020 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgsogo jgsogo jgsogo approved these changes

Assignees

@jgsogo jgsogo

Labels
None yet
Projects
None yet
Milestone
1.21.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@memsharded @jgsogo