Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 'six.string_types' to check if default options are strings #6322

Merged
merged 4 commits into from Jan 10, 2020
Merged

Use 'six.string_types' to check if default options are strings #6322

merged 4 commits into from Jan 10, 2020

Conversation

jgsogo
Copy link
Contributor

@jgsogo jgsogo commented Jan 9, 2020 •
edited

Changelog: Fix: use six.string_types to check if default options are strings
Docs: omit

I'm not able to reproduce the issue in our CI, but I think that it is safe to merge this change.

closes #6321

@jgsogo jgsogo added this to the 1.21.1 milestone Jan 9, 2020
@jgsogo jgsogo changed the title add test reproducing #6321 Use 'six.string_types' to check if default options are strings Jan 9, 2020
@jgsogo jgsogo marked this pull request as ready for review January 9, 2020 12:25
@jgsogo jgsogo requested a review from memsharded January 9, 2020 12:32
@memsharded memsharded merged commit cc4bf8b into conan-io:release/1.21.1 Jan 10, 2020
@jgsogo jgsogo deleted the fix/default_options-unicode branch January 10, 2020 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@memsharded memsharded Awaiting requested review from memsharded

Assignees

@memsharded memsharded

Labels
None yet
Projects
None yet
Milestone
1.21.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jgsogo @memsharded