Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'six.string_types' to check if default options are strings #6322

Merged

Conversation

@jgsogo
Copy link
Member

jgsogo commented Jan 9, 2020

Changelog: Fix: use six.string_types to check if default options are strings
Docs: omit

I'm not able to reproduce the issue in our CI, but I think that it is safe to merge this change.

closes #6321

@jgsogo jgsogo added this to the 1.21.1 milestone Jan 9, 2020
@jgsogo jgsogo changed the title add test reproducing #6321 Use 'six.string_types' to check if default options are strings Jan 9, 2020
@jgsogo jgsogo marked this pull request as ready for review Jan 9, 2020
@jgsogo jgsogo requested a review from memsharded Jan 9, 2020
@memsharded memsharded merged commit cc4bf8b into conan-io:release/1.21.1 Jan 10, 2020
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/jenkins/pr-head This commit cannot be built
Details
license/cla Contributor License Agreement is signed.
Details
@jgsogo jgsogo deleted the jgsogo:fix/default_options-unicode branch Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.