Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Python 3.8 #6355

Merged
merged 6 commits into from Jan 16, 2020
Merged

[ci] Python 3.8 #6355

merged 6 commits into from Jan 16, 2020

Conversation

jgsogo
Copy link
Member

@jgsogo jgsogo commented Jan 14, 2020

Changelog: Bugfix: Fix broken compression of .tgz files due to Python 3.8 changing tar default schema.
Changelog: Fix: Recipe substitution for scm (old behavior) fixed for multiline comments in Python 3.8.
Docs: conan-io/docs#1526

#PYVERS: py38
#tags: slow, svn
#revisions: 1

@jgsogo jgsogo changed the title [wip][ci] Python 3.8 [ci] Python 3.8 Jan 15, 2020
@jgsogo jgsogo added this to the 1.22 milestone Jan 15, 2020
@jgsogo jgsogo self-assigned this Jan 15, 2020
@jgsogo
Copy link
Member Author

@jgsogo jgsogo commented Jan 16, 2020

This is running py38 for all the platforms and many Python versions (py38, py36, py27) and with/out revisions. It also includes your changes from #6348.

I think it is what we need to say "Conan support py38" (we need to run the preflight and full test suite, but we are close enough)

@jgsogo jgsogo requested a review from memsharded Jan 16, 2020
@jgsogo jgsogo assigned danimtb and unassigned jgsogo Jan 16, 2020
Copy link
Member

@memsharded memsharded left a comment

Take the changelog (or similar) from my PR, and then my PR can be closed.

@jgsogo jgsogo merged commit 6d57495 into conan-io:develop Jan 16, 2020
2 checks passed
@jgsogo jgsogo deleted the py38/fix_tests branch Jan 16, 2020
jgsogo added a commit to jgsogo/conan that referenced this issue Jan 29, 2020
* fixing some broken tests for python 3.8

* fix test for AST replacement

* fixing missing error msg in server

Co-authored-by: James <james@conan.io>
jgsogo added a commit that referenced this issue Jan 30, 2020
* [ci] Python 3.8 (#6355)

* fixing some broken tests for python 3.8

* fix test for AST replacement

* fixing missing error msg in server

Co-authored-by: James <james@conan.io>

* py38 different bufsize default

* improving data test (#6341)

Co-authored-by: James <james@conan.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants