refactoring runners and pyinstaller SCM fix #6380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memsharded
commented
Jan 17, 2020
memsharded
changed the title
jgsogo
approved these changes
Jan 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Cleaning
LD_LIBRARY_PATHenvironment inSCMcommands for "pyinstaller" installations, as SSL can fail due to using old SSL stuff from Conan instead from git/svn.Docs: Omit
It contains mostly a refactor, centralizing executions and subprocess stuff (not all of it, but most of it from production code). The only functional change is to introduce the pyinstaller fix in the SCM run() method.
Close #6161
#tags: slow