Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test/lockfile requires options #6395

Merged
merged 2 commits into from Jan 29, 2020
Merged

Test/lockfile requires options #6395

merged 2 commits into from Jan 29, 2020

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Jan 20, 2020 •
edited

Changelog: Bugfix: Lockfiles were not correctly applying locked options to packages, which produced incorrect evaluation of requirements() method.
Docs: Omit

#tags: slow
#revisions: 1

Fix #6383

@memsharded memsharded added this to the 1.22 milestone Jan 27, 2020
@memsharded memsharded self-assigned this Jan 29, 2020
@memsharded memsharded merged commit 773d73c into conan-io:develop Jan 29, 2020
@memsharded memsharded deleted the test/lockfile_requires_options branch January 30, 2020 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgsogo jgsogo jgsogo approved these changes

@czoido czoido czoido approved these changes

Assignees

@memsharded memsharded

Labels
None yet
Projects
None yet
Milestone
1.22
Development

Successfully merging this pull request may close these issues.

[bug] Default options from lockfile are not applied in the requirements() method when calling conan create
3 participants
@memsharded @jgsogo @czoido