-
Notifications
You must be signed in to change notification settings - Fork 957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Append CONAN_LIBS and CONAN_SYSTEM_LIBS CMake variables to avoid overwriting user-defined libs #6433
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is for 1.22, then it should take into account #6298
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to test these changes taking into account the other PR 🙌 Indeed, that one is about targets and shouldn't interfere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, please create a 1.21.2 release branch and target this PR to it.
Thanks!
@memsharded This PR is running Conan Right now the CI uses py38 unconditionally, we could add some kind of if/else conditions in the CI source based on the branch name to remove it from the CI matrix, but I feel like it would be cleaner to backport Python 3.8 changes to this branch too (in fact we should backport it to any Conan version we consider alive). 👍 or 👎 ? |
@danimtb, We are adding Python 3.8 to |
Changelog: Bugfix: Append
CONAN_LIBS
incmake
generator to avoid overwriting user-defined libs.Docs: omit
develop
branch, documenting this one.Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.