Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Conan inspect when remote.json is not created #6559

Merged
merged 2 commits into from Feb 18, 2020

Conversation

uilianries
Copy link
Member

@uilianries uilianries commented Feb 18, 2020

Changelog: Fix: inspect command can be executed without remote.json (#6558)
Docs: Omit

fixes #6558

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries uilianries changed the title #6558 Reproduce inspect error #6558 Fix Conan inspect when remote.json is not created Feb 18, 2020
@uilianries uilianries changed the title #6558 Fix Conan inspect when remote.json is not created Fix Conan inspect when remote.json is not created Feb 18, 2020
@jgsogo jgsogo added this to the 1.23 milestone Feb 18, 2020
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries uilianries marked this pull request as ready for review Feb 18, 2020
@uilianries uilianries closed this Feb 18, 2020
@uilianries uilianries reopened this Feb 18, 2020
@memsharded memsharded merged commit 6f9ed25 into conan-io:develop Feb 18, 2020
2 checks passed
@luka-papez
Copy link

@luka-papez luka-papez commented Oct 22, 2021

Has this really been fixed? I am using 1.41.0 and trying to do:
conan inspect --raw version conanfile.py (on any conanfile)
which results in:
ERROR: Error loading conanfile at '/home/gradle/conanfile.py': No remote defined when remotes.json does not exits.

Its not a big deal as I can still get the version by simply grepping the conanfile, but just wanted to double check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants