Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible solution for conan config install #6601

Merged

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Mar 2, 2020

Changelog: Fix: Remove file before copying in conan config install to avoid permission issues.
Docs: Omit

Close #6556

jgsogo
jgsogo approved these changes Mar 18, 2020
Copy link
Member

@jgsogo jgsogo left a comment

Does this change deserve a test? Probably with the comment linking the original issue it is enough

@jgsogo jgsogo added this to the 1.24 milestone Mar 18, 2020
@memsharded
Copy link
Member Author

@memsharded memsharded commented Mar 18, 2020

I tried to make a test, but it was difficult, it is not easy to make an automated test to make this fail, it requires another user, it doesn't work the same in all OSs...

@jgsogo
Copy link
Member

@jgsogo jgsogo commented Mar 19, 2020

Then I think this is ready to merge and it'll close the original issue.

@memsharded memsharded merged commit b5d3088 into conan-io:develop Mar 19, 2020
2 checks passed
@memsharded memsharded deleted the feature/config_install_permissions branch Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants