Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake overwrites Conan VS runtime when CMP0091 is NEW #6626

Merged
merged 5 commits into from Mar 5, 2020

Conversation

czoido
Copy link
Contributor

@czoido czoido commented Mar 5, 2020

Changelog: Bugfix: Check the CMP0091 policy and set CMAKE_MSVC_RUNTIME_LIBRARY accordingly to CONAN_LINK_RUNTIME if it's set to NEW.
Docs: omit

Fix #6624

Starting in CMake 3.15, unless you specify cmake_policy(SET CMP0091 OLD) the values that Conan is setting are overwritten.
Now the MSVC_RUNTIME_LIBRARY has to be set, instead of setting the MSVC runtime in CMAKE_<LANG>_FLAGS_<CONFIG>.

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Raising the minimum required CMake version to 3.16 breaks macro conan_set_vs_runtime
2 participants