CMake overwrites Conan VS runtime when CMP0091 is NEW #6626
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Bugfix: Check the
CMP0091
policy and setCMAKE_MSVC_RUNTIME_LIBRARY
accordingly toCONAN_LINK_RUNTIME
if it's set toNEW
.Docs: omit
Fix #6624
Starting in CMake 3.15, unless you specify
cmake_policy(SET CMP0091 OLD)
the values that Conan is setting are overwritten.Now the
MSVC_RUNTIME_LIBRARY
has to be set, instead of setting the MSVC runtime inCMAKE_<LANG>_FLAGS_<CONFIG>
.develop
branch, documenting this one.Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.