Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpp_info.components first iteration #6653

Merged
merged 24 commits into from Mar 23, 2020
Merged

Conversation

danimtb
Copy link
Member

@danimtb danimtb commented Mar 10, 2020

Changelog: Feature: Add cpp_info.components package creator interface to model internal dependencies inside a recipe.
Docs: conan-io/docs#1363

This PR covers the following:

  • cpp_info.components to define different "targets" at recipe creator level
  • deps_cpp_info.components is not available, all the info can be only consumed in a "global" or per dependency way taking into account the new info introduced by each component.
  • dependency among components is not modeled yet. Components are iterated in insertion order.
  • Components cannot be defined inside components (as said above, dependency among components will be implemented in a separate PR)
  • Components cannot be defined per configuration. This means no cpp_info.release.components["name"].... is allowed. This has been left for future consideration.

Additional points after review:

  • Components have default directory values when created: includedirs, bindirs, libdirs...
  • Mixing Components and "global" values is not allowed in the same recipe.
  • Components DO filter paths (same behavior as cpp_info).

  • Refer to the issue that supports this Pull Request: closes #5090, closes #2387
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

@danimtb danimtb added this to the 1.24 milestone Mar 10, 2020
@danimtb danimtb self-assigned this Mar 10, 2020
conans/model/build_info.py Outdated Show resolved Hide resolved
@danimtb danimtb changed the title Feature/components cpp_info.components first iteration Mar 11, 2020
@danimtb danimtb marked this pull request as ready for review Mar 11, 2020
@danimtb danimtb requested review from jgsogo and memsharded Mar 11, 2020
jgsogo
jgsogo approved these changes Mar 11, 2020
Copy link
Member

@jgsogo jgsogo left a comment

I like what I see 🙌 just really quick comments, don't take them seriously.

conans/model/build_info.py Show resolved Hide resolved
conans/model/build_info.py Outdated Show resolved Hide resolved
Copy link
Member

@memsharded memsharded left a comment

Looking good!
Please have a look to the comments.

conans/model/build_info.py Show resolved Hide resolved
conans/model/build_info.py Show resolved Hide resolved
conans/model/build_info.py Outdated Show resolved Hide resolved
conans/model/build_info.py Outdated Show resolved Hide resolved
conans/model/build_info.py Show resolved Hide resolved
conans/model/build_info.py Outdated Show resolved Hide resolved
conans/test/unittests/model/build_info/components_test.py Outdated Show resolved Hide resolved
Copy link
Member

@jgsogo jgsogo left a comment

Good! Let's see if we can tackle those two comments. Thanks!

conans/model/build_info.py Outdated Show resolved Hide resolved
conans/model/build_info.py Show resolved Hide resolved
jgsogo
jgsogo approved these changes Mar 19, 2020
Copy link
Member

@jgsogo jgsogo left a comment

💪 Great!


Docs needed

@danimtb
Copy link
Member Author

@danimtb danimtb commented Mar 23, 2020

Added docs at conan-io/docs#1363

@memsharded memsharded merged commit b36307f into conan-io:develop Mar 23, 2020
2 checks passed
@uilianries
Copy link
Member

@uilianries uilianries commented Mar 23, 2020

we have components!

the office

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants