using LF for .sh generators #6670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is almost passing, except the Windows test. def package_info(self):
# Basic variable
self.env_info.USER_VAR = r"some value with space and \\ (backslash)"As I am doing a total replace of backslashes, then this is a problem. Any suggestion? |
jgsogo
reviewed
Mar 12, 2020
I'm the user and we should ignore this, because I couldn't reproduce it: see #6662 (comment) |
jgsogo
suggested changes
Mar 16, 2020
There was a problem hiding this comment.
It looks like that the file ending can be merged, but not the path modification according to @jokram , who is doing an exhaustive investigation: #6662 (comment) So, at least, these two things have to be separated in different PRs
jgsogo
suggested changes
Mar 26, 2020
|
Yes, agree to everything, reviewed. |
jgsogo
approved these changes
Mar 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Bugfix: Use always LF line separator for .sh scripts generated by
virtualenvgenerators.Docs: Omit
Close #6662
Trying to see if this breaks something
#tags: slow