Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vcvars_arch usage before assignment. #6675

Merged

Conversation

rasjani
Copy link
Contributor

@rasjani rasjani commented Mar 13, 2020

Changelog: Bugfix: Fix vcvars_arch usage before assignment, that can cause a crash in tools.vcvars_command() that is also used internally by MSBuild helper.
Docs: Omit

Fixes: #6674

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

@rasjani rasjani changed the title Fix vsvars_arch usage before assignment. Fix vcvars_arch usage before assignment. Mar 13, 2020
@rasjani rasjani force-pushed the feature/fix-reference-before-assignment branch from fefcb00 to 344f1b3 Compare Mar 13, 2020
@memsharded
Copy link
Member

@memsharded memsharded commented Mar 13, 2020

It would have been good to have a test for this, but as it is an obvious fix, lets merge it.
Thanks for contributing it!

@memsharded memsharded added this to the 1.24 milestone Mar 13, 2020
@memsharded memsharded merged commit b8b3070 into conan-io:develop Mar 13, 2020
2 checks passed
sthagen added a commit to sthagen/conan-io-conan that referenced this issue Mar 13, 2020
Fix vcvars_arch usage before assignment. (conan-io#6675)
@rasjani rasjani deleted the feature/fix-reference-before-assignment branch Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants