Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#6693 Check for description in JSON output #6724

Merged
merged 4 commits into from Mar 25, 2020

Conversation

uilianries
Copy link
Member

@uilianries uilianries commented Mar 24, 2020

Changelog: Feature: Add the description field to the output of the conan info command.
Docs: conan-io/docs#1627

Add the field "description" as valid for the command Conan info.

closes #6693

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

uilianries added 2 commits Mar 24, 2020
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Copy link
Member

@memsharded memsharded left a comment

Looks good, just a small question.

conans/test/functional/command/info_test.py Show resolved Hide resolved
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@memsharded memsharded added this to the 1.24 milestone Mar 24, 2020
jgsogo
jgsogo approved these changes Mar 25, 2020
Copy link
Member

@jgsogo jgsogo left a comment

The original PR will modify also the output of the conan info --help command, it should add the description field to the -n/--only argument. We need to modify here in the docs the "Reference >> Commands >> Create >> Info" output

jgsogo
jgsogo approved these changes Mar 25, 2020
Copy link
Member

@jgsogo jgsogo left a comment

Sorry, my previous review was for the docs, not the PR itself 🤦‍♂

conans/test/functional/command/info_test.py Outdated Show resolved Hide resolved
Co-Authored-By: Javier G. Sogo <jgsogo@gmail.com>
jgsogo
jgsogo approved these changes Mar 25, 2020
@jgsogo jgsogo merged commit 97c705e into conan-io:develop Mar 25, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants