Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sun C/C++ Compiler Version Detection #6757

Merged
merged 1 commit into from Mar 29, 2020
Merged

Conversation

metaphox
Copy link
Contributor

@metaphox metaphox commented Mar 29, 2020

Changelog: Bugfix: Fixes the auto-detection of sun-cc compiler when it outputs Studio 12.5 Sun C.
Docs: Omit

This fix the bug where the output of suncc -V reads:

cc: Studio 12.5 Sun C 5.14 SunOS_sparc 2016/05/31

and causes 12.5 rather than 5.14 to be captured as the version number of the C compiler.

Fix #6749

This fix the bug where the output of `suncc -V` reads:
```
cc: Studio 12.5 Sun C 5.14 SunOS_sparc 2016/05/31
```
and causes 12.5 rather than 5.14 to be captured as the version number of the C compiler.
@CLAassistant
Copy link

@CLAassistant CLAassistant commented Mar 29, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@memsharded memsharded left a comment

Looks good, I like that you have left the previous code as fallback when "Sun C." is not in the output.

@memsharded memsharded added this to the 1.24 milestone Mar 29, 2020
@memsharded memsharded merged commit 02ccf9e into conan-io:develop Mar 29, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants