Fix: handle compiler flags for Intel C++ (AutoToolsBuildEnvironment, Meson) #6819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SSE4
commented
Apr 8, 2020
SSE4
force-pushed
the
intel_autotools
branch
7 times, most recently
from
39a7428
to
c6bc503
Compare
SSE4
commented
Apr 8, 2020
| @@ -100,8 +100,8 @@ def gcc_test(self): | |||
| settings.build_type = "Release" | |||
| gcc = GCCGenerator(conan_file) | |||
| # GCC generator ignores the compiler setting, it is always gcc | |||
There was a problem hiding this comment.
I don't know what's the story behind of this, but it's basically:
- useless
- incorrect
SSE4
force-pushed
the
intel_autotools
branch
2 times, most recently
from
386904a
to
7f37807
Compare
SSE4
commented
Apr 9, 2020
SSE4
changed the title
danimtb
approved these changes
Jun 3, 2020
memsharded
reviewed
Jun 3, 2020
Signed-off-by: SSE4 <tomskside@gmail.com>
jgsogo
approved these changes
Jun 4, 2020
There was a problem hiding this comment.
Thanks for all these changes, not only a new feature but a nice refactor around many functions. I think it is a big leap forward. Nevertheless, for the future, as a general rule, I'd prefer to review 4 PRs that to have here unrelated changes... what if we need to rollback some of these changes? 😮
🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #5699
this PR adds handling of compiler flags (e.g. PIC, arch, etc.) for Intel C++ compiler.
since for Intel C++ compiler flags are different for various compiler bases, I have changed most of the internal interfaces in compiler_flags module to accept settings object.
this should allow more flexibility.
this mostly impacts the
AutoToolsBuildEnvironmentHelper, but also few generators and other build helpers using the compiler_flags functions.locally tested on a few recipes: libiconv, libxml2, OpenSSL
Changelog: Fix: Handle compiler flags for Intel C++ (AutoToolsBuildEnvironment, Meson).
Docs: omit
developbranch, documenting this one.Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.