Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: handle compiler flags for Intel C++ (AutoToolsBuildEnvironment, Meson) #6819

Merged
merged 1 commit into from Jun 5, 2020

Conversation

SSE4
Copy link
Contributor

@SSE4 SSE4 commented Apr 8, 2020

related: #5699

this PR adds handling of compiler flags (e.g. PIC, arch, etc.) for Intel C++ compiler.
since for Intel C++ compiler flags are different for various compiler bases, I have changed most of the internal interfaces in compiler_flags module to accept settings object.
this should allow more flexibility.
this mostly impacts the AutoToolsBuildEnvironmentHelper, but also few generators and other build helpers using the compiler_flags functions.

locally tested on a few recipes: libiconv, libxml2, OpenSSL

Changelog: Fix: Handle compiler flags for Intel C++ (AutoToolsBuildEnvironment, Meson).
Docs: omit

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

@SSE4 SSE4 force-pushed the intel_autotools branch 7 times, most recently from 39a7428 to c6bc503 Compare Apr 8, 2020
@@ -100,8 +100,8 @@ def gcc_test(self):
settings.build_type = "Release"
gcc = GCCGenerator(conan_file)
# GCC generator ignores the compiler setting, it is always gcc
Copy link
Contributor Author

@SSE4 SSE4 Apr 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what's the story behind of this, but it's basically:

  1. useless
  2. incorrect

@SSE4 SSE4 force-pushed the intel_autotools branch 2 times, most recently from 386904a to 7f37807 Compare Apr 9, 2020
@SSE4 SSE4 changed the title Fix: handle compiler flags for Intel C++ Fix: handle compiler flags for Intel C++ (AutoToolsBuildEnvironment, Meson) May 6, 2020
@danimtb danimtb added this to the 1.26 milestone May 12, 2020
@danimtb danimtb requested a review from memsharded May 12, 2020
@danimtb danimtb self-assigned this May 12, 2020
danimtb
danimtb approved these changes Jun 3, 2020
@memsharded memsharded requested a review from jgsogo Jun 3, 2020
Signed-off-by: SSE4 <tomskside@gmail.com>
jgsogo
jgsogo approved these changes Jun 4, 2020
Copy link
Member

@jgsogo jgsogo left a comment

Thanks for all these changes, not only a new feature but a nice refactor around many functions. I think it is a big leap forward. Nevertheless, for the future, as a general rule, I'd prefer to review 4 PRs that to have here unrelated changes... what if we need to rollback some of these changes? 😮

🎉

@memsharded memsharded merged commit 471a2a0 into conan-io:develop Jun 5, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants