Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing GCC version to settings.yml #6911

Merged
merged 1 commit into from Apr 28, 2020

Conversation

johnmcfarlane
Copy link
Contributor

@johnmcfarlane johnmcfarlane commented Apr 26, 2020

This version is already apt package, g++-10, in Ubuntu 20.04.

Changelog: Fix: Adds missing version GCC 10 to default settings.
Docs: conan-io/docs#1675

Fix #6910
Fix #6920

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

@CLAassistant
Copy link

CLAassistant commented Apr 26, 2020

CLA assistant check
All committers have signed the CLA.

@johnmcfarlane johnmcfarlane changed the base branch from master to develop April 26, 2020 14:34
johnmcfarlane added a commit to johnmcfarlane/docs that referenced this pull request Apr 26, 2020
This version is already apt package, g++-10, in Ubuntu 20.04.
@memsharded
Copy link
Member

Lets release this for next 1.25.

Please @SSE4 , can you provide the default cppstd of this compiler version in the codebase?

@johnmcfarlane
Copy link
Contributor Author

Lets release this for next 1.25.

Please @SSE4 , can you provide the default cppstd of this compiler version in the codebase?

99% certain it's 14. Trunk is 14 and when when I try the same test in an Ubuntu 20.04 docker container (johnmcfarlane/cnl_ci:gcc-10) it also reports 14.
Thanks

@SSE4
Copy link
Contributor

SSE4 commented Apr 28, 2020

I confirm it's C++14, thus no changes for cppstd_default are needed.

g++ -dM -E -x c++  /dev/null | grep __cplus
#define __cplusplus 201402L

@memsharded memsharded merged commit 48911ba into conan-io:develop Apr 28, 2020
memsharded pushed a commit to conan-io/docs that referenced this pull request Apr 28, 2020
@johnmcfarlane johnmcfarlane deleted the patch-1 branch December 24, 2021 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] support gcc 10 [bug] Missing support for newer compilers
4 participants