Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vcvars_dict should accept a conanfile too #7010

Merged
merged 2 commits into from May 15, 2020
Merged

vcvars_dict should accept a conanfile too #7010

merged 2 commits into from May 15, 2020

Conversation

jgsogo
Copy link
Contributor

@jgsogo jgsogo commented May 13, 2020 •
edited by czoido

Changelog: Fix: vcvars_dict should accept a conanfile too.
Docs: conan-io/docs#1696

These changes should have been included in #6916

closes #7009

@jgsogo jgsogo mentioned this pull request May 13, 2020
Merged
@jgsogo jgsogo added this to the 1.26 milestone May 13, 2020
@jgsogo jgsogo marked this pull request as ready for review May 13, 2020 16:08
@jgsogo jgsogo requested a review from danimtb May 13, 2020 16:09
@memsharded memsharded merged commit 918d198 into conan-io:develop May 15, 2020
@jgsogo jgsogo deleted the fix/vcvars-conanfile branch May 18, 2020 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@memsharded memsharded memsharded left review comments

@danimtb danimtb danimtb approved these changes

Assignees

@memsharded memsharded

Labels
None yet
Projects
None yet
Milestone
1.26
Development

Successfully merging this pull request may close these issues.

[bug] Propagate conanfile parameter in vcvars tools
3 participants
@jgsogo @danimtb @memsharded