Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes https://github.com/conan-io/conan/issues/7022 #7024

Merged
merged 1 commit into from May 17, 2020

Conversation

eyebrowsoffire
Copy link
Contributor

@eyebrowsoffire eyebrowsoffire commented May 15, 2020

Changelog: Bugfix: Fixes an issue where Apple Framework lookup wasn't working on RelWithDebInfo CMake build types.
Docs: Omit

Close #7022

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

@memsharded
Copy link
Member

memsharded commented May 17, 2020

Excellent, thanks! this goes to next 1.26 release, but I will backport it too to 1.25.2

@memsharded memsharded merged commit aaacc42 into conan-io:develop May 17, 2020
2 checks passed
@memsharded memsharded added this to the 1.26 milestone May 17, 2020
memsharded pushed a commit to memsharded/conan that referenced this issue May 17, 2020
jgsogo pushed a commit that referenced this issue May 18, 2020
Co-authored-by: eyebrowsoffire <gardjack@justin.tv>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants