Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix user_info getattr #7131

Merged
merged 1 commit into from Jun 2, 2020
Merged

fix user_info getattr #7131

merged 1 commit into from Jun 2, 2020

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Jun 2, 2020 •
edited by czoido

Changelog: Bugfix: Getting attribute of self.deps_user_info["dep"] now raise AttributeError instead of a (wrong) KeyError, enabling hasattr() and correct getattr() behaviors.
Docs: omit

Fix: #7130

@memsharded memsharded added this to the 1.26 milestone Jun 2, 2020
@memsharded memsharded mentioned this pull request Jun 2, 2020
Closed
@uilianries
Copy link
Member

@memsharded I've added a new test for AttributeError, please take a look: memsharded#35

@memsharded memsharded merged commit f3fb851 into conan-io:develop Jun 2, 2020
@memsharded memsharded deleted the fix/user_info_getattr branch June 2, 2020 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgsogo jgsogo jgsogo approved these changes

@danimtb danimtb danimtb approved these changes

@uilianries uilianries Awaiting requested review from uilianries

Assignees

@danimtb danimtb

Labels
None yet
Projects
None yet
Milestone
1.26
Development

Successfully merging this pull request may close these issues.

[question] Safe way to check for presence of a key in deps_user_info?
4 participants
@memsharded @uilianries @jgsogo @danimtb