Start testing some features and changes for the cli in Conan V2 #7170
Conversation
conans/cli/command.py
Outdated
| args = parser.parse_args(*args) | ||
|
|
||
| try: | ||
| info = self._conan.search_recipes(args.query, remote_pattern=args.remote, |
There was a problem hiding this comment.
Different api calls for remotes and cache? Otherwise the "exclusive" argument check needs to be duplicated inside the api.
There was a problem hiding this comment.
I was thinking that maybe we could allow searching in the remote and the cache at the same time. WDYT?
There was a problem hiding this comment.
Might be possible, indeed. Lets discuss it with the team.
conans/cli/command.py
Outdated
| try: | ||
| info = self._conan.search_recipes(args.query, remote_pattern=args.remote, | ||
| local_cache=args.cache) | ||
| except ConanException as exc: |
There was a problem hiding this comment.
This repeated pattern everywhere is ugly. I think we should try to avoid it when possible, and extract the behavior to a common place when not possible.
I would remove it at the moment, and leave a flow without try-except.
| from conans.search.search import (search_recipes) | ||
|
|
||
|
|
||
| class Search(object): |
There was a problem hiding this comment.
An object, without state, is probably better a function, you can pass the app as argument, it will have the collaborators inside.
There was a problem hiding this comment.
I haven't cloned this branch, so don't take too seriously these comments
-
if formatters are so coupled with the commands, probably they could be just methods. And I would prefer to add them in the same file as the command itself, I think it simplifies distribution.
-
I think those formatters doesn't belong to the
conans.clientmodule, but toconans.cli: -
I would return the data structure from the command and let the output handle it
These suggestions will turn the command definition into something like:
@conan_command(group="Misc commands", cli=output_help_cli, json=output_help_json,...)
def help(*args, **kwargs):
...
return help_output
def output_help_cli(out, help_output, *args, **kwargs):
...There can be other strategies to associate output to commands (I'm not sure if those output can be reused by different commands)
Co-authored-by: Javier G. Sogo <jgsogo@gmail.com>
Co-authored-by: Javier G. Sogo <jgsogo@gmail.com>
Co-authored-by: Javier G. Sogo <jgsogo@gmail.com>
Co-authored-by: Javier G. Sogo <jgsogo@gmail.com>
There was a problem hiding this comment.
Too many things in one PR. Lets split it in 2 or more PRs:
- One PR first with the infrastructure for commands mgmt. Can implement just the "search" method with a hardcoded result in 1 line, empty "conan_api", 1 formatter
- After that is merged, it would be nice to proceed one command at a time, and a lot of the internal functionality is worth revisiting. In that case, it could be separate in one PR for the interface (cli, conan_api), then another for the internal.
- Also the internal can be duplicated if modifying the existing code is too risky and could break.
|
Replaced by: #7278 and upcoming PR |
Changelog: Feature: Draft to start testing some features that are being discussed for Conan CLI 2.0.
Docs: https://github.com/conan-io/docs/pull/XXXX
Define env var
CONAN_V2_CLIto use.