Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Use 'profile_build' (if given) to create graph for the test_package functionality #7182

Merged
merged 8 commits into from Jun 30, 2020

Conversation

jgsogo
Copy link
Member

@jgsogo jgsogo commented Jun 10, 2020

Changelog: Fix: Graph created for the test_package/conanfile.py recipe takes the profile:build if given.
Docs: omit

Related to some comments in #7132 (comment)

The test_package functionality was not taking into account the profile:build so the tools.cross_building tool was not able to identify context properly... and build_requires in the test_package recipe didn't assign to the proper context.

@jgsogo jgsogo marked this pull request as draft Jun 10, 2020
Copy link
Member Author

@jgsogo jgsogo left a comment

Still some doubts I need to test

conans/client/cmd/build.py Outdated Show resolved Hide resolved
conans/client/graph/graph_manager.py Outdated Show resolved Hide resolved
conans/client/graph/graph_manager.py Outdated Show resolved Hide resolved
@jgsogo jgsogo self-assigned this Jun 10, 2020
@jgsogo jgsogo added this to the 1.27 milestone Jun 19, 2020
Copy link
Member

@memsharded memsharded left a comment

I'd say this is already good as-is, despite other possible fixes or other open issues

conans/test/functional/cross_building/test_package_test.py Outdated Show resolved Hide resolved
@jgsogo jgsogo marked this pull request as ready for review Jun 29, 2020
@jgsogo
Copy link
Member Author

@jgsogo jgsogo commented Jun 29, 2020

I've removed the TODOs and refactor the new tests to avoid duplicated code. I also think it is good as it is.

@jgsogo jgsogo requested a review from memsharded Jun 29, 2020
@jgsogo jgsogo assigned danimtb and unassigned jgsogo Jun 29, 2020
@danimtb danimtb merged commit 64599cf into conan-io:develop Jun 30, 2020
2 checks passed
@jgsogo jgsogo deleted the fix/xbuild-test_package branch Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants