New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for all Linux distros using apt #7309
Add support for all Linux distros using apt #7309
Conversation
c5230ab
to
664c727
Compare
664c727
to
cba4503
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say that it is extremely unlikely that some distro will have other thing different to apt, located in /usr/bin/apt
.
What I am not 100% sure is that all those different distros will have apt
located in that exact place, and not elsewhere. Have you checked that?
Thanks for contributing this!
@seanballais I am also not sure, may apt reside for instance in directories like in |
@SSE4, @memsharded, I updated the check based on your feedback. I detracted though a bit, and checked for |
@seanballais yes, this definitely might be a problem, I suspect text might be different for different locales, e.g. it could display Spanish translation for es-es, etc.:
just running something like |
@SSE4, I've just changed the check from using |
520301a
to
0919f7d
Compare
Fixes #7307
Changelog: Feature: Checking if a Linux distro uses
apt
is now based on the existence ofapt
in the system, instead of checking if the distro currently being used is in a hard-coded list of distros known to useapt
.Docs: omit