Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add (recover) quotes around link flags #7322

Merged
merged 4 commits into from Jul 9, 2020

Conversation

jgsogo
Copy link
Contributor

@jgsogo jgsogo commented Jul 7, 2020

Changelog: Bugfix: Recover quotes around linker flags in CMake generators, fix failure with Macos frameworks
Docs: omit

In PR #6780 we lost the quotes we were adding around frameworks, without them CMake generated files are not valid, and the link step fails (#7321).

Note.- This is reintroduced for backward compatibility, but the proper way to declare the frameworks is to add them to the cpp_info.frameworks dedicated list:

                def package_info(self):
                    if not self.options.use_components:
                        # self.cpp_info.exelinkflags.extend(['-framework Foundation'])
                        self.cpp_info.frameworks.extend(['Foundation'])
                    else:
                        # self.cpp_info.components["cmp"].exelinkflags.extend(['-framework Foundation'])
                        self.cpp_info.components["cmp"].frameworks.extend(['Foundation'])

Fix #7321
Close #1251

@jgsogo jgsogo added this to the 1.27.1 milestone Jul 7, 2020
@czoido czoido merged commit 20472c3 into conan-io:release/1.27 Jul 9, 2020
@jgsogo jgsogo deleted the fix/link_flags-quotes branch July 9, 2020 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants