#7328 Add 'outdated' column in search table #7364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
|
The CI could not find the branch ... I've pushed the commit at same time than I submitted this PR. |
memsharded
requested changes
Jul 15, 2020
|
|
||
| def test_search_outdated(self): | ||
|
|
||
| def validate_outdated_table(expected): |
There was a problem hiding this comment.
This seems a bit interleaved with other checks, and a bit fragile for changes. Try to simplify the checks, or do a separate, very simple test.
There was a problem hiding this comment.
Done. I separated the test, also I using single package id, so it should not change in the future.
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
jgsogo
added a commit
to jgsogo/conan
that referenced
this pull request
Jul 17, 2020
jgsogo
added a commit
that referenced
this pull request
Jul 17, 2020
memsharded
pushed a commit
to noizex/conan
that referenced
this pull request
Jul 21, 2020
* conan-io#7328 Add 'outdated' column in search table Signed-off-by: Uilian Ries <uilianries@gmail.com> * conan-io#7328 do not remove more than requested Signed-off-by: Uilian Ries <uilianries@gmail.com> * conan-io#7328 Separate functional test Signed-off-by: Uilian Ries <uilianries@gmail.com> * conan-io#7328 Update other test to support outdated column Signed-off-by: Uilian Ries <uilianries@gmail.com>
memsharded
pushed a commit
to noizex/conan
that referenced
this pull request
Jul 21, 2020
memsharded
added a commit
that referenced
this pull request
Jul 21, 2020
… user (#7390) * Only add User-Agent to headers dict if there was none provided by the user * [cpp_info] [refact] Do not assign to 'xxxx_paths' fields (#7276) * use get_configs instead of config * fixing tests * fix tests * fix tests * move pkg_config logic to cpp_info so everyone uses the same * 'name' from cpp_info needs the generator it is requested for * configs is a private dict now * revert change in init * add test for Conan v2 behavior * deps_cpp_info['deps'].name warns to use get_name instead * use cpp_info properly * compare as lists (convert possible iterables to lists) * set legit values in cpp_info * readonly fields expected to be iterable (not nessessaryly lists) * remove print statement from test * let any iterable type in * revert test changes * use property 'configs' to retrieve the different configs * check type for cpp_info/deps_cpp_info objects * just a list * Do not fail with 'conan remove -r remote -p' if there are no packages in the remote (#7338) * remove only if there are packages to remove * working on v1 too * no need to scape an r-string * v1 -> no revs * if not conaninfo, search doesn't work * propagate 404 only if there are packages for the reference * Update conans/client/rest/rest_client_v1.py Co-authored-by: James <james@conan.io> * when it is not none * package_ids is always a list. Capture unrelated errors Co-authored-by: James <james@conan.io> * [cpp_info] [refact] Rewrite text generator parser (#7277) * use get_configs instead of config * fixing tests * fix tests * fix tests * move pkg_config logic to cpp_info so everyone uses the same * 'name' from cpp_info needs the generator it is requested for * configs is a private dict now * revert change in init * add test for Conan v2 behavior * deps_cpp_info['deps'].name warns to use get_name instead * some attributes doesn't make sense at the base level * rewrite txt parser * revert test changes * use property 'configs' to retrieve the different configs * Avoid usage of '__len__' hook * fixing test: never root * read names from txt serialization * the only information that is serialized in the 'txt' generated file is the name for the txt generator * use ordereddict to retrieve deps in order * add test for next Conan v2 * remove commented lines * remove unused method * wrong behavior in py2 for it scope * fix tests in windows * revert single change * relax msbuild generator to not fail in Linux (#7361) * relax msbuild generator to not fail in Linux * fix test * cli 2.0: Add commands management (#7278) * add management for commands 2.0 * refactor cli * fail on empty docs * rename _conan to _conan_api * minimum required version * add fixme for conan factory * add discuss * raise on not allowed formatter * refactor weird try, except, finally pattern * change output handling * remove weird pattern * minor changes * move exception handling * use formatters as dictonary * minor changes * do not allow empty remotee * add output argument only if there are formatters * move exit codes * change default formatter * add init * conditional generators test with configure() (#7359) * conditional generators test with configure() * fixing test * fixing test * adding generators in the command line * #7328 Add 'outdated' column in search table (#7364) * #7328 Add 'outdated' column in search table Signed-off-by: Uilian Ries <uilianries@gmail.com> * #7328 do not remove more than requested Signed-off-by: Uilian Ries <uilianries@gmail.com> * #7328 Separate functional test Signed-off-by: Uilian Ries <uilianries@gmail.com> * #7328 Update other test to support outdated column Signed-off-by: Uilian Ries <uilianries@gmail.com> * #7364 No need for an additional test (#7373) * implementing __contains__ for option in self.info.options (#7303) * implementing __contains__ for option in self.info.options * add test * more tests * clarified test * changed self.info.options.whatever to raise * improve tests * fix tests * Update conans/test/functional/package_id/package_id_test.py Co-authored-by: Javier G. Sogo <jgsogo@gmail.com> * Update conans/test/functional/package_id/package_id_test.py Co-authored-by: Javier G. Sogo <jgsogo@gmail.com> * fixed test Co-authored-by: Javier G. Sogo <jgsogo@gmail.com> * minor pep8 in conan_api.py * contribute test Co-authored-by: Javier G. Sogo <jgsogo@gmail.com> Co-authored-by: James <james@conan.io> Co-authored-by: Carlos Zoido <mrgalleta@gmail.com> Co-authored-by: Uilian Ries <uilianries@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Show outdated packages when running
search --table.Docs: conan-io/docs#1771
This hotfix adds the column outdated to the default HTML table generated by
search --table. That was the usual behavior until Conan 1.24. After that, the new format removed the colors which indicated if a package is outdated (yellow) or not (green).fixes #7328
/cc @memsharded @jgsogo
developbranch, documenting this one.Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.