Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #7383 by adding cppstd to QNX QCC in settings and #7426 by adding version 8.3 #7384

Merged
merged 3 commits into from Jul 27, 2020

Conversation

mjvankampen
Copy link
Contributor

@mjvankampen mjvankampen commented Jul 19, 2020

Changelog: Bugfix: cppstd was missing in settings.yml for the qcc compiler and updates to 8.3.
Docs: Omit

I am not sure though if I also need to update the documents

Close #7383
Close #7426

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

@CLAassistant
Copy link

CLAassistant commented Jul 19, 2020

CLA assistant check
All committers have signed the CLA.

@mjvankampen mjvankampen changed the title Adds cppstd to QNX QCC in settings Fixes #7383 by adding cppstd to QNX QCC in settings Jul 19, 2020
@mjvankampen mjvankampen changed the title Fixes #7383 by adding cppstd to QNX QCC in settings Fixes #7383 by adding cppstd to QNX QCC in settings and #7426 by adding version 8.3 Jul 27, 2020
@memsharded memsharded added this to the 1.28 milestone Jul 27, 2020
@memsharded memsharded requested a review from SSE4 July 27, 2020 09:02
@memsharded
Copy link
Member

Thanks for contributing this!

Yeah, I think we are good without docs. For this cases you can put:

Docs: Omit

In the comment.

If the PR closes open issues, you can also put it as:

Close #7383
Close #7426

So when the PR is merged, those issues are automatically closed.

Many thanks!

@memsharded memsharded merged commit e33df7b into conan-io:develop Jul 27, 2020
@mjvankampen mjvankampen deleted the fix/qcc-cppstd branch July 27, 2020 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Update qcc to latest version [bug] QCC compiler is missing cppstd
4 participants