-
Notifications
You must be signed in to change notification settings - Fork 957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: add deprecated attribute #7399
Conversation
95021ff
to
7c9bc41
Compare
Signed-off-by: SSE4 <tomskside@gmail.com>
7c9bc41
to
5af724b
Compare
NOTE: this doesn't print:
instead, it will print just:
notice taskflow has no version specified. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering if this deprecated
attribute is prone to be ser conditionally in the configure()
method. Having a look at the implementation, I think it is already working but I am not sure if we have a use case for that 🤔
Well, it is possible that some recipe support for one OS is deprecated, probably not a very common case, so I would be fine even if this didn't work at the moment. |
I don't see any advantage in such complicated use-case as a conditionally deprecated recipe. I'd say let's go with simple implementation, until someone will actually request that feature. |
One advantage using the current condition, is that we can give a hint to the new reference. This new feature doesn't offer the same case. Maybe, deprecated could accept a package reference or a boolean: class Foo(ConanFile):
...
deprecated = True
# OR
deprecated = "foobar/0.1.0" # new reference |
@uilianries both are allowed, boolean and reference |
closes: #7251
Changelog: Feature: add deprecated attribute
Docs: conan-io/docs#1775
develop
branch, documenting this one.Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.