Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Propagate 'user_info_build' using package development commands #7488

Merged
merged 10 commits into from Aug 5, 2020
Merged

[fix] Propagate 'user_info_build' using package development commands #7488

merged 10 commits into from Aug 5, 2020

Conversation

jgsogo
Copy link
Contributor

@jgsogo jgsogo commented Aug 4, 2020 •
edited by czoido

Changelog: Feature: Add user_info_build attribute to txt generator.
Changelog: Fix: Attribute user_info_build is available for commands in the local development workflow.
Docs: omit

Fixing issue mentioned in #7247 (comment)

@jgsogo jgsogo mentioned this pull request Aug 4, 2020
Closed
@jgsogo jgsogo self-assigned this Aug 4, 2020
@jgsogo jgsogo mentioned this pull request Aug 4, 2020
Merged
@jgsogo jgsogo added this to the 1.28.1 milestone Aug 4, 2020
@jgsogo jgsogo changed the base branch from develop to release/1.28 August 4, 2020 17:37
@jgsogo jgsogo marked this pull request as ready for review August 5, 2020 08:21
@jgsogo jgsogo requested a review from czoido August 5, 2020 09:17
@jgsogo jgsogo assigned memsharded and unassigned jgsogo Aug 5, 2020
memsharded
memsharded approved these changes Aug 5, 2020
View reviewed changes
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parsing is a bit obscure, but that is the nature of the file, so I am good with this.

@jgsogo jgsogo merged commit e157492 into conan-io:release/1.28 Aug 5, 2020
@jgsogo jgsogo deleted the fix/user_info-build branch August 5, 2020 14:30
@jgsogo jgsogo mentioned this pull request Aug 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czoido czoido czoido approved these changes

@memsharded memsharded memsharded approved these changes

Assignees

@czoido czoido

@memsharded memsharded

Labels
None yet
Projects
None yet
Milestone
1.28.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jgsogo @czoido @memsharded