Bugfix: use CMAKE_FIND_ROOT_PATH_BOTH to locate frameworks

[SSE4]

closes: #6416

test case adapted from https://github.com/Paultergeist/conan_apple_framework

see find_library documentation.

Changelog: Bugfix: Use CMAKE_FIND_ROOT_PATH_BOTH to locate frameworks.
Docs: omit

• Refer to the issue that supports this Pull Request.
• If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
• I've read the Contributing guide.
• I've followed the PEP8 style guides for Python code.
• I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

^{Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.}

[memsharded]

It would be great to know when we could use NO_DEFAULT_PATH, because we fully know this is a framework that lives in the Conan package, and forget about all the system paths, and when it would be a system framework and then it could be found in other locations rather than in the ${CONAN_FRAMEWORK_DIRS${SUFFIX}}

Now that we have the system_libs, this could be the same for frameworks? system_frameworks?

Wdyt @danimtb, @jgsogo ?

[lasote]

Makes sense. It would be a better model. (Not to do it in this PR, but something to do)

[jgsogo]

Agree. Then we should turn this bugfix into a feature for 1.29

[danimtb]

yes, I think having a cpp_info.system_frameworks makes sense

[SSE4]

it makes sense, but it will be much larger change - e.g. update several generators at least

[danimtb]

yes, I am not saying that it is a change for this PR, but something to consider for a feature

[jgsogo]

If I understand correctly the documentation about find_package, using CMAKE_FIND_ROOT_PATH_BOTH is the default behavior, in fact the proposed tests already pass without the source changes.

[SSE4]

@jgsogo do you have proof? did you try it to run the test locally with no CMAKE_FIND_ROOT_PATH_BOTH specified?
cause I did, and it fails for me without specifying it.
reading the CMake source code I see that for iOS the default mode is ONLY:
https://github.com/Kitware/CMake/blob/master/Modules/Platform/Darwin.cmake#L10

[jgsogo]

Sorry, my fault. There are two classes with tests in that file and I was running the wrong one.

Indeed the change is needed to find those frameworks in the cross-compiling scenario