Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for cpp_info.system_libs to QMake generator #7563



Copy link

@ttencate ttencate commented Aug 19, 2020

Changelog: Bugfix: Add support for cpp_info.system_libs to QMake generator.
Docs: Omit

Fix #7558

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

Copy link

CLAassistant commented Aug 19, 2020

CLA assistant check
All committers have signed the CLA.

@jgsogo jgsogo added this to the 1.29 milestone Aug 19, 2020
jgsogo approved these changes Aug 19, 2020
@memsharded memsharded merged commit 4654095 into conan-io:develop Aug 19, 2020
2 checks passed
Copy link

memsharded commented Aug 19, 2020

Nice, clean and with testing, perfect at first shot, good job!
Will be included and released in next Conan 1.29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

[bug] QMake generator does not honour system_libs
4 participants