Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export intel_installation_path and compilervars* from tools module #7572

Merged
merged 2 commits into from Sep 28, 2020

Conversation

ohanar
Copy link
Contributor

@ohanar ohanar commented Aug 20, 2020

Changelog: Feature: Expose intel_installation_path, compilervars, compilervars_dict, and compilervars_command under tools module in order to support usage of the intel compiler.
Docs: conan-io/docs#1815

closes: #7554

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

@ohanar
Copy link
Contributor Author

ohanar commented Aug 20, 2020

The compilervars helper functions are already documented, even though they aren't exported. I added documentation for the intel_installation_path helper.

SSE4
SSE4 approved these changes Aug 23, 2020
@ohanar
Copy link
Contributor Author

ohanar commented Sep 16, 2020

Is there anything blocking merging this? I don't have permissions to view what failed on the CI, but I cannot produce any issues locally.

@memsharded memsharded merged commit c42738d into conan-io:develop Sep 28, 2020
2 of 3 checks passed
@memsharded memsharded added this to the 1.30 milestone Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Export compilervars in conans.tools
4 participants