Handle unknown statement while parsing profile. Fixes #6931

[iblancasa]

Changelog: Bugfix: Provide a more descriptive error when an unknown statement is added to a profile
Docs: omit

Closes: #6931

Tested with the example provided in the examples repository

I replaced the first line:

include(default)

By:

includes(default)

When running conan before this change, the command output is:

✗ ./build.sh
+ conan remove 'conan-hello-emscripten/*' -f
WARN: No package recipe matches 'conan-hello-emscripten/*'
+ conan create . conan/testing -pr emscripten.profile --build missing
ERROR: Error reading 'emscripten.profile' profile: Error parsing the profile text file: not enough values to unpack (expected 2, got 1)

After this change:

✗ ./build.sh
+ conan remove 'conan-hello-emscripten/*' -f
WARN: No package recipe matches 'conan-hello-emscripten/*'
+ conan create . conan/testing -pr emscripten.profile --build missing
ERROR: Error reading 'emscripten.profile' profile: Error while parsing line 0: 'includes(default)'

[CLAassistant]

All committers have signed the CLA.

[memsharded]

Fix looks good. Please check the comment about the exception.

It would be great to include a test that covers this case. Do you think you could manage to add it? profile_loader_test.py seems a good place. Ask for help if need it, we could contribute the test if you prefer.

[memsharded]

Let's throw a generic ConanException. New exceptions will be introduced from now on, only if it is going to be captured and processed somewhere else. Let's keep it simple.

[memsharded]

I hadn't check the CI, please check: https://conan-ci.jfrog.info/blue/organizations/jenkins/ConanTestSuite/detail/PR-7577/1/pipeline

One of the test was producing a different output, the test can be changed (and also adding a new one that valides the includes() error too)

[iblancasa]

Ok, I added the requested changes except the tests. I'm trying to figure out what test I broke because, when I run tox, I get:

FAILED (SKIP=250, errors=30, failures=2)

Even if I run those tests from develop. I'm running the tests in a Fedroa 31 machine. Can be related? Do I need a specific environment? If yes, do you think it can make sense to create a Dockerfile to help developers to run tests?

[memsharded]

Even if I run those tests from develop. I'm running the tests in a Fedroa 31 machine. Can be related? Do I need a specific environment? If yes, do you think it can make sense to create a Dockerfile to help developers to run tests?

Yes, setting up the whole environment might be a bit complicated, and a docker image will only partially help, because there might be easily tests failing in other platforms, other python versions, etc. Typically having a look at our CI and running those failing tests manually (with nosetests conans.test.functional...) is good enough for development, this is what I do many times, when not in my main OS.

In your case: https://conan-ci.jfrog.info/blue/organizations/jenkins/ConanTestSuite/detail/PR-7577/2/pipeline, so probably running nosetests conans.test.functional.command.install.install_test.InstallTest is good enough.

[memsharded]

Perfect, thanks!