Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'conan config' type argument #7583

Merged
merged 3 commits into from Aug 25, 2020

Conversation

uilianries
Copy link
Member

@uilianries uilianries commented Aug 24, 2020

Changelog: Fix: Support installing configs from non-regular files.
Docs: conan-io/docs#1818

NOTE this PR comes from #7124

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

@CLAassistant
Copy link

CLAassistant commented Aug 24, 2020

CLA assistant check
All committers have signed the CLA.

Signed-off-by: Uilian Ries <uilianries@gmail.com>
conans/client/command.py Show resolved Hide resolved
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Copy link
Member

@memsharded memsharded left a comment

I think the client.run('config install httpnonexisting --type=dir') should be an error too, this seems like a current bug? Please check it.

conans/test/functional/command/config_install_test.py Outdated Show resolved Hide resolved
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries uilianries closed this Aug 25, 2020
@uilianries uilianries reopened this Aug 25, 2020
@uilianries uilianries requested a review from memsharded Aug 25, 2020
@memsharded memsharded added this to the 1.29 milestone Aug 25, 2020
@memsharded memsharded merged commit 972492d into conan-io:develop Aug 25, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants