Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: respect winsdk_version for WindowsStore #7584

Merged
merged 1 commit into from Aug 30, 2020

Conversation

SSE4
Copy link
Contributor

@SSE4 SSE4 commented Aug 24, 2020

closes: #7305

Changelog: Bugfix: Respect winsdk_version for WindowsStore.
Docs: omit

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

Signed-off-by: SSE4 <tomskside@gmail.com>
@SSE4 SSE4 force-pushed the vcvars_winsdk_version branch from 44f9282 to 2ab6d86 Compare Aug 24, 2020
@memsharded memsharded added this to the 1.29 milestone Aug 30, 2020
@memsharded memsharded merged commit 46b55d6 into conan-io:develop Aug 30, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] vcvars_command doesn't allow setting custom winsdk_version
2 participants