Fix component checking for non-standard requirements #7585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
private and overridden requirements shouldn't be used as requirements for components
ohanar
force-pushed
the
fix_components_check
branch
from
dc031c4
to
9ea9bd4
Compare
memsharded
reviewed
Oct 12, 2020
There was a problem hiding this comment.
This contribution seems correct, sorry that it was buried in the backlog and never reviewed.
Private packages information shouldn't be propagated downstream, and override requirements shouldn't be direct ones, and shouldn't be used in components requires IIRC.
Lets make a review and try to integrate this into next release.
danimtb
approved these changes
Oct 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Private and overridden requirements shouldn't be used as requirements for components.
Closes #7907.
Changelog: Fix: Component requirement checking now properly handles private and override requirements.
Docs: Omit