Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add system libs and frameworks to components targets #7611

Conversation

czoido
Copy link
Contributor

@czoido czoido commented Aug 28, 2020

Changelog: Fix: Add system libs and frameworks to components targets in cmake_find_package and cmake_find_package_multi generators.
Docs: omit

When system_libs were added to components like in this recipe: https://github.com/conan-io/conan-center-index/blob/a5605be7613edeb705801440b69db2709e16be79/recipes/xorg/all/conanfile.py#L28 those libs are not added to the components targets, that's the reason why this is failing: https://travis-ci.org/github/conan-io/examples/jobs/721587427

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

@czoido czoido added this to the 1.28.2 milestone Aug 28, 2020
jgsogo
jgsogo approved these changes Aug 28, 2020
Copy link
Contributor

@jgsogo jgsogo left a comment

My review is summarized in these two comments here: #7602 (comment)

@memsharded memsharded merged commit f48724f into conan-io:release/1.28 Aug 30, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants