Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for system_libs and frameworks for Qbs generator #7619

Merged
merged 1 commit into from Aug 30, 2020
Merged

Add support for system_libs and frameworks for Qbs generator #7619

merged 1 commit into from Aug 30, 2020

Conversation

Psy-Kai
Copy link
Contributor

@Psy-Kai Psy-Kai commented Aug 30, 2020

Changelog: Feature: Added support for cpp_info.system_libs, cpp_info.framework_paths and cpp_info.frameworks for qbs generator.
Docs: Omit

partially implements #6008

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

@CLAassistant
Copy link

CLAassistant commented Aug 30, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, many thanks.
We don't have specific unit test for this generator, I guess you managed to run it locally from sources with the changes, and it is working for you, isn't it?

@memsharded memsharded added this to the 1.29 milestone Aug 30, 2020
@Psy-Kai
Copy link
Contributor Author

Psy-Kai commented Aug 30, 2020

Looks good, many thanks.
We don't have specific unit test for this generator, I guess you managed to run it locally from sources with the changes, and it is working for you, isn't it?

Yes. I modified my running conan instance and used the Qbs generator before uploading the code.

@memsharded memsharded merged commit 86400ea into conan-io:develop Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants