Fix copying symlink to directories (2) #7655
Conversation
|
Thank you for your contribution. I will reach you with some tests regarding the changes here. |
|
Hi @hifabian and sorry for the delay. I have added a test for the fix you proposed. Thank you! |
|
ping @hifabian |
…deploy-symlink-dirs
|
Thank you for writing the tests! |
conans/test/utils/genconanfile.py
Outdated
| if self._package_folders: | ||
| lines.extend([' tools.mkdir(os.path.join(self.package_folder, "{}"))' | ||
| ''.format(folder) for folder in self._package_folders]) | ||
| if self._package_folders_link: |
There was a problem hiding this comment.
I would say that this is an overly test-specific thing, that this should be implemented directly in the test, leaving GenConanfile() more generic. Only common conanfile patterns should be here.
It is true that the _package_files_link was already there, but that pattern is used just exactly once in the whole codebase, so probably that deserved to be specified in the test directly, and not generalized here.
Asking @jgsogo for a second opinion.
There was a problem hiding this comment.
Yes, I think the same. GenConanfile must be something generic... even if it cannot be used for some tests. Sometimes it is also better to write the plain conanfile source if it helps to understand what we are testing.
There was a problem hiding this comment.
...but this argument also applies to the with_package_file(..., link) that is already in the GenConanfile, only used once.
There was a problem hiding this comment.
Yeah, this is what I meant with:
It is true that the _package_files_link was already there, but that pattern is used just exactly once in the whole codebase, so probably that deserved to be specified in the test directly, and not generalized here.
package_files_link shouldn't be in GenConanfile, but in the specific test that is using it.
There was a problem hiding this comment.
Please @danimtb move the test specific code to the test, and leave GenConanfile generic
| class DeployGeneratorSymbolicLinkFolderTest(unittest.TestCase): | ||
|
|
||
| def setUp(self): | ||
| conanfile = textwrap.dedent(""" |
There was a problem hiding this comment.
We typically indent the content inside the textwrap.dedent
Co-authored-by: Javier G. Sogo <jgsogo@gmail.com>
Changelog: Bugfix: Copy symbolic links to directory with deploy generator.
Docs: conan-io/docs#1830
(corrected user compared to #7654 to accept CLA)
fixes #7647
(no updated tests)
developbranch, documenting this one.Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.