Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Depends item for every public_dep of the conanfiles deps #7729

Merged
merged 2 commits into from Sep 21, 2020
Merged

Add Depends item for every public_dep of the conanfiles deps #7729

merged 2 commits into from Sep 21, 2020

Conversation

Psy-Kai
Copy link
Contributor

@Psy-Kai Psy-Kai commented Sep 21, 2020

Changelog: Feature: Added Depends items for every public dependency of conanfiles requires/dependencies.
Docs: conan-io/docs#1847

Fixes #7728.

The usage of publilc_deps is based on the implementation of the pkg_config generator.

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

@memsharded memsharded self-assigned this Sep 21, 2020
@memsharded memsharded added this to the 1.30 milestone Sep 21, 2020
Copy link
Member

@memsharded memsharded left a comment

Thanks for this contribution!
I have added a unit test, to make sure this doesn't break in the future.
Lets merge it for next Conan 1.30 release.

@memsharded memsharded merged commit 1fd02ef into conan-io:develop Sep 21, 2020
2 checks passed
@Psy-Kai Psy-Kai deleted the feature/make-qbs-generator-transitive branch Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Make Qbs generator transitive
2 participants