Adding CMake ABI support for armv5el and armv5hf architecture #7730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kuklinistvan
changed the title
armv5el and armv5hf architecture
kuklinistvan
changed the title
armv5el and armv5hf architecture
memsharded
approved these changes
Sep 23, 2020
|
Added unit test in: 63b44ec |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: BugFix: Add
armv5hfandarmv5elto the Android ABI architectures.Docs: Omit
Makes CMake support compiling for older Android ARM CPU by mapping
armv5elandarmv5hfarchitectures to thearmeabiABI. Without this, CMake is going to complain for an unknown ABI whenarchis set toarmv5elorarmv5hfin the Conan profile, as CMake expectsCMAKE_ANDROID_ARCH_ABIto be set to one of the values documented here.Refer to the issue that supports this Pull Request.If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.I've opened another PR in the Conan docs repo to the(no interface was changed)developbranch, documenting this one.I have skipped most of the above steps because this is such a tiny modification that even this pull request contains more work already than those two lines added to the mapping function (maybe not if we count using the modification version) :)