New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/detect libcxx #7776
Feature/detect libcxx #7776
Conversation
#include <string> | ||
|
||
using namespace std; | ||
static_assert(sizeof(std::string) != sizeof(void*), "using libstdc++"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
static_assert is C++11, can we use it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we can just include and check the value of _GLIBCXX_USE_CXX11_ABI
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is only applied for gcc>=5.1 which already support c++11 (passed in the command line)
maybe we can just include and check the value of _GLIBCXX_USE_CXX11_ABI?
That is the original problem, as you described in #7264 (comment), this will be ignored. We need to check for the real thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, I see, you're passing -std=c++11
below
I can't see the warning message when running it on CentOS6 + Devtools7:
For regular GCC7 docker image, based on Ubuntu, it works fine:
Steps to reproduce:
|
This will not warn if it checks the libcxx correctly, it will just assign the correct value, and seems to work ok, doesn't it? |
Hmm, correct! |
Changelog: Feature: Implement real detection of
compiler.libcxx
value forgcc
compiler. Only enabled inCONAN_V2_MODE
, otherwise it would be breaking.Docs: Omit
Close #7264