Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update message on create_settings when settings are constrained #7930

Merged
merged 2 commits into from Oct 23, 2020

Conversation

sdmg15
Copy link
Contributor

@sdmg15 sdmg15 commented Oct 23, 2020

Changelog: Fix: displayed message when settings of the recipe are constrained.
Docs: conan-io/docs#1890
Closes #6802

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

@sdmg15
Copy link
Contributor Author

sdmg15 commented Oct 23, 2020

I wanted to edit the link that point to the documentation here
https://github.com/conan-io/conan//blob/8e2cac4b086b3d425dc05d938f18146d10a188e4/conans/model/settings.py#L11
But seems it's tight to other settings?

@sdmg15 sdmg15 marked this pull request as draft Oct 23, 2020
@memsharded
Copy link
Member

Please check the failing test in https://conan-ci.jfrog.info/blue/organizations/jenkins/ConanTestSuite/detail/PR-7930/1/pipeline.

There is a test that was explicitly testing this error message.

@memsharded
Copy link
Member

I wanted to edit the link that point to the documentation here
https://github.com/conan-io/conan//blob/8e2cac4b086b3d425dc05d938f18146d10a188e4/conans/model/settings.py#L11
But seems it's tight to other settings?

Yes, that is more about the mismatch of values with settings.yml, while the message you are changing is about constraints that a recipe impose on the possible settings. So just changing the msg seems good enough.

@memsharded memsharded added this to the 1.31 milestone Oct 23, 2020
@sdmg15
Copy link
Contributor Author

sdmg15 commented Oct 23, 2020

Please check the failing test in https://conan-ci.jfrog.info/blue/organizations/jenkins/ConanTestSuite/detail/PR-7930/1/pipeline.

There is a test that was explicitly testing this error message.

I got 404
Edit: Can access it already

@sdmg15
Copy link
Contributor Author

sdmg15 commented Oct 23, 2020

I wanted to edit the link that point to the documentation here
https://github.com/conan-io/conan//blob/8e2cac4b086b3d425dc05d938f18146d10a188e4/conans/model/settings.py#L11
But seems it's tight to other settings?

Yes, that is more about the mismatch of values with settings.yml, while the message you are changing is about constraints that a recipe impose on the possible settings. So just changing the msg seems good enough.

So how could I update the link on the displayed message? As you can see I updated the documentation too, so I'll need the link displayed on the message pointing to the in the Q&A. Is that line the right one?

@danimtb
Copy link
Member

danimtb commented Oct 23, 2020

@sdmg15 thanks for the PR! Please add a meaningful changelog line in the description of the PR as a fix, that way we can include it for the next release 😄

@sdmg15
Copy link
Contributor Author

sdmg15 commented Oct 23, 2020

@danimtb Updated :)

@sdmg15 sdmg15 marked this pull request as ready for review Oct 23, 2020
@danimtb danimtb merged commit 0c8ce29 into conan-io:develop Oct 23, 2020
2 checks passed
@danimtb
Copy link
Member

danimtb commented Oct 23, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Raise ConanInvalidConfiguration from recipes constraining settings
3 participants