New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update message on create_settings when settings are constrained #7930
update message on create_settings when settings are constrained #7930
Conversation
I wanted to edit the link that point to the documentation here |
Please check the failing test in https://conan-ci.jfrog.info/blue/organizations/jenkins/ConanTestSuite/detail/PR-7930/1/pipeline. There is a test that was explicitly testing this error message. |
Yes, that is more about the mismatch of values with settings.yml, while the message you are changing is about constraints that a recipe impose on the possible settings. So just changing the msg seems good enough. |
I got 404 |
So how could I update the link on the displayed message? As you can see I updated the documentation too, so I'll need the link displayed on the message pointing to the in the Q&A. Is that line the right one? |
@sdmg15 thanks for the PR! Please add a meaningful changelog line in the description of the PR as a fix, that way we can include it for the next release 😄 |
@danimtb Updated :) |
Thanks! |
Changelog: Fix: displayed message when settings of the recipe are constrained.
Docs: conan-io/docs#1890
Closes #6802
develop
branch, documenting this one.Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.