avoid loading config when not running migrations #7949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uilianries
reviewed
Oct 28, 2020
| self.cache = ClientCache(cache_folder, out) | ||
| super(ClientMigrator, self).__init__(self.cache.cache_folder, self.cache.store, | ||
| current_version, out) | ||
| self.cache_folder = cache_folder |
There was a problem hiding this comment.
Okay, cache_folder can't be None, because ConanAPI forces an object.
uilianries
approved these changes
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Avoid unnecessary extra loading of conan.conf file in the version migrations check.
Docs: Omit
Discover this while investigating: #7948
We are loading the conan.conf too many times. One of them is for migrations, even if migration is not necessary, not executed, creating a
ClientCache()object unnecessarily loads the config. Delayed it instantiation to avoid it.