New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better UX error for migrations #7966
Conversation
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
…ome-permission
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
There is a note on chmod docs: https://docs.python.org/2.7/library/os.html#os.chmod "Although Windows supports chmod(), you can only set the file’s read-only flag with it (via the stat.S_IWRITE and stat.S_IREAD constants or a corresponding integer value). All other bits are ignored." However, it works for files, not for folder. Signed-off-by: Uilian Ries <uilianries@gmail.com>
I skipped Windows test because os.chmod has no effect under Windows folders, I would need other libraries, like pywin32 or oschmod. The documentation is clear about Windows support: https://docs.python.org/2.7/library/os.html#os.chmod
It works for file only ... For some reason, if I inject I also tried subprocess call with |
I didn't find specific test file only related to Migrator or ClientMigrator, so I created an unit test to validate the current error message.
This change should affect more tests, as now
save
raises an error. Let's see ...Changelog: Fix: Improve permission error message when migrating cache folder.
Docs: Omit
Related to #7948
/cc @ngrodzitski @memsharded
develop
branch, documenting this one.Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.