fix short_path folders removal #7986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgsogo
suggested changes
Nov 5, 2020
| except OSError as e: | ||
| raise ConanException("%s\n\nFolder: %s\n" | ||
| "Couldn't remove folder, might be busy or open\n" | ||
| "Close any app using it, and retry" % (scm_folder, str(e))) |
There was a problem hiding this comment.
In this message, I'm always missing information about the actual path being removed, the shortened one, which would be the one blocking. I agree with the changes as they are now, but this is something to improve.
There was a problem hiding this comment.
But the OSError exception should contain the failing path, and the exception is printed too, right?
There was a problem hiding this comment.
Uhm, that's probably right, but I cannot test it outside Windows...
jgsogo
approved these changes
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Bugfix: Remove correctly short-paths folders in Windows.
Docs: Omit
Fix #7983
#tags: slow, svn
#revisions: 1