Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/generate #8101

Merged
merged 18 commits into from Nov 24, 2020
Merged

Feature/generate #8101

merged 18 commits into from Nov 24, 2020

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Nov 23, 2020 •
edited by czoido

Changelog: Feature: Deprecate experimental toolchain() in favor of more generic generate() method. Deprecate toolchains write_toolchain_files() to new generate() method.
Docs: conan-io/docs#1940

#tags: slow

@memsharded memsharded added this to the 1.32 milestone Nov 23, 2020
@memsharded memsharded self-assigned this Nov 23, 2020
jgsogo
jgsogo suggested changes Nov 24, 2020
View reviewed changes
conans/client/conanfile/configure.py Show resolved Hide resolved
conan/tools/microsoft/toolchain.py Show resolved Hide resolved
conan/tools/microsoft/toolchain.py Show resolved Hide resolved
conans/client/generators/__init__.py Show resolved Hide resolved
conans/client/generators/__init__.py Outdated Show resolved Hide resolved
conans/client/generators/__init__.py Outdated Show resolved Hide resolved
conans/test/functional/toolchain/test_txt_cmdline.py Outdated Show resolved Hide resolved
jgsogo
jgsogo approved these changes Nov 24, 2020
View reviewed changes
Copy link
Contributor

@jgsogo jgsogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! Just a typo

conan/tools/cmake/base.py Outdated Show resolved Hide resolved
memsharded and others added 2 commits November 24, 2020 19:01
@memsharded @jgsogo
Update conan/tools/cmake/base.py
c00342b 
Co-authored-by: Javier G. Sogo <jgsogo@gmail.com>
@memsharded
fix indent
d1933e9
@memsharded memsharded merged commit 6e25cc8 into conan-io:develop Nov 24, 2020
@memsharded memsharded deleted the feature/generate branch November 24, 2020 21:04
This was referenced Dec 1, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgsogo jgsogo jgsogo approved these changes

@czoido czoido Awaiting requested review from czoido

Assignees

@memsharded memsharded

Labels
None yet
Projects
None yet
Milestone
1.32
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@memsharded @jgsogo