Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linkage to a same global target of different package components in CMake generators #8114

Merged

Conversation

danimtb
Copy link
Member

@danimtb danimtb commented Nov 26, 2020

Changelog: BugFix: Fix linkage to a same global target of different package components in cmake_find_package/_multi generators.
Docs: conan-io/docs#1946

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

@danimtb danimtb added this to the 1.32 milestone Nov 26, 2020
@danimtb danimtb requested a review from jgsogo November 26, 2020 10:53
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is looking good, maybe improving the tests to make sure that the APPEND work, and nonstd::nonstd is now the accumulated of all.

@jgsogo jgsogo assigned jgsogo and unassigned memsharded Nov 26, 2020
@danimtb danimtb requested a review from jgsogo November 26, 2020 17:54
Copy link
Contributor

@jgsogo jgsogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, I would modify the changelog, IMO this is more like a feature.

(I'm not merging because develop is 🔴 for several builds now and I don't want to add more noise if something is really broken)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants