New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix linkage to a same global target of different package components in CMake generators #8114
Fix linkage to a same global target of different package components in CMake generators #8114
Conversation
conans/test/functional/generators/components/cmake_find_package_multi_test.py
Outdated
Show resolved
Hide resolved
conans/test/functional/generators/components/cmake_find_package_multi_test.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is looking good, maybe improving the tests to make sure that the APPEND work, and nonstd::nonstd
is now the accumulated of all.
conans/test/functional/generators/components/cmake_find_package_test.py
Outdated
Show resolved
Hide resolved
conans/test/functional/generators/components/cmake_find_package_test.py
Outdated
Show resolved
Hide resolved
conans/test/functional/generators/components/cmake_find_package_multi_test.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw, I would modify the changelog, IMO this is more like a feature.
(I'm not merging because develop
is 🔴 for several builds now and I don't want to add more noise if something is really broken)
Changelog: BugFix: Fix linkage to a same global target of different package components in
cmake_find_package/_multi
generators.Docs: conan-io/docs#1946
develop
branch, documenting this one.Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.