Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/short paths info paths #8181

Merged

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Dec 9, 2020

Changelog: Bugfix: Fix errors when using conan info --paths and short_paths=True in Windows, due to creation of empty folders in the short-paths storage.
Docs: Omit

Fix #8172

@memsharded memsharded added this to the 1.32.1 milestone Dec 9, 2020
@czoido czoido closed this Dec 10, 2020
@czoido czoido reopened this Dec 10, 2020
@memsharded memsharded marked this pull request as ready for review December 10, 2020 09:01
client.save({"conanfile.py": GenConanfile().with_short_paths(True)})
client.run("export . test/1.0@")
client.run("info test/1.0@ --paths")
client.run("info test/1.0@ --paths")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to call the same command twice?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is exactly the test. The second one is raising if you do not implement the fix.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can clarify it with a comment

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, no problem, it is said in the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants